fix(ui5-dialog): announce content for VoiceOver when used as message box#13596
Closed
kskondov wants to merge 1 commit into
Closed
fix(ui5-dialog): announce content for VoiceOver when used as message box#13596kskondov wants to merge 1 commit into
kskondov wants to merge 1 commit into
Conversation
VoiceOver on macOS does not announce the dialog content when focus lands on a button inside the dialog. An aria-live region is now used to announce text-only content when the dialog opens.
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13596--ui5-webcomponents.netlify.app |
GerganaKremenska
requested changes
May 27, 2026
Contributor
There was a problem hiding this comment.
We should not add aria-live to a dialog. This is a Voiceover (macOs) issue. The issue is reproducible with native html and since webcomponents support standards, not vendors we should close the issue. Simple HTML example - https://jsbin.com/tozinuseqa/edit?html,output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VoiceOver on macOS does not announce the dialog content when focus lands on a button inside the dialog. An aria-live region is now used to announce text-only content when the dialog opens.
Fixes: #13572